Skip to content

Conversation

@elianiva
Copy link
Contributor

@elianiva elianiva commented Jun 14, 2025

Related GitHub Issue

Picked up work from #2806 since it has been marked as stale.

Description

I feel like the current history UI is a bit outdated. This PR makes it look and feel more consistent with the rest.

Here's what's been done:

  • Moved all style props into tailwindcss
  • Refactored some components so they are more consistent with one another
  • Adjusted some stylings to be more consistent
  • Make compact and full variant of TaskItem more consistent
  • Moved information into one place so it's easier to look at all of them
  • Changed the filter UI to use dropdown instead of the messy radio and checkbox
  • Updated / added tests for the history components

Test Procedure

Open the history menu, it should show the new UI. I didn't change much apart from the TaskItem component

Type of Change

  • 🐛 Bug Fix: Non-breaking change that fixes an issue.
  • New Feature: Non-breaking change that adds functionality.
  • 💥 Breaking Change: Fix or feature that would cause existing functionality to not work as expected.
  • ♻️ Refactor: Code change that neither fixes a bug nor adds a feature.
  • 💅 Style: Changes that do not affect the meaning of the code (white-space, formatting, etc.).
  • 📚 Documentation: Updates to documentation files.
  • ⚙️ Build/CI: Changes to the build process or CI configuration.
  • 🧹 Chore: Other changes that don't modify src or test files.

Pre-Submission Checklist

  • Issue Linked: This PR is linked to an approved GitHub Issue (see "Related GitHub Issue" above).
  • Scope: My changes are focused on the linked issue (one major feature/fix per PR).
  • Self-Review: I have performed a thorough self-review of my code.
  • Code Quality:
    • My code adheres to the project's style guidelines.
    • There are no new linting errors or warnings (npm run lint).
    • All debug code (e.g., console.log) has been removed.
  • Testing:
    • New and/or updated tests have been added to cover my changes.
    • All tests pass locally (npm test).
    • The application builds successfully with my changes.
  • Branch Hygiene: My branch is up-to-date (rebased) with the main branch.
  • Documentation Impact: I have considered if my changes require documentation updates (see "Documentation Updates" section below).
  • Changeset: A changeset has been created using npm run changeset if this PR includes user-facing changes or dependency updates.
  • Contribution Guidelines: I have read and agree to the Contributor Guidelines.

Screenshots / Videos

These screenshots are side-by-side comparison with the old UI. (left is the new one, right is the old one)

image

image

Documentation Updates

This is only UI changes, no need for documentation update

Get in Touch

@elianiva


Important

Refactor history UI for consistency, update filter UI, and add tests for components and dialogs.

  • UI Refactor:
    • Moved inline style props to Tailwind CSS in HistoryView.tsx and other components.
    • Refactored TaskItem, TaskItemHeader, and TaskItemFooter for consistency.
    • Updated filter UI in HistoryView.tsx to use dropdowns instead of radio and checkbox.
  • Components:
    • Added DeleteButton.tsx for task deletion with optional confirmation.
    • Updated CopyButton.tsx and ExportButton.tsx for consistent styling and behavior.
  • Tests:
    • Added tests for CopyButton, DeleteButton, ExportButton, TaskItem, TaskItemHeader, TaskItemFooter, and useTaskSearch.
    • Added BatchDeleteTaskDialog.test.tsx and DeleteTaskDialog.test.tsx for dialog interactions.
  • Localization:
    • Updated localization files for multiple languages to reflect UI changes.

This description was created by Ellipsis for 9e10cb6b798962898889cf896fd0f9cb75f18168. You can customize this summary. It will automatically update as commits are pushed.

@elianiva elianiva requested review from cte, jr and mrubens as code owners June 14, 2025 03:31
@dosubot dosubot bot added size:XXL This PR changes 1000+ lines, ignoring generated files. UI/UX UI/UX related or focused labels Jun 14, 2025
@elianiva elianiva force-pushed the feat/better-history-ui branch from 9e10cb6 to b0a67a4 Compare June 14, 2025 03:33
@elianiva elianiva force-pushed the feat/better-history-ui branch from c59b7e1 to 2b69d42 Compare June 14, 2025 03:42
@hannesrudolph hannesrudolph added the Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. label Jun 14, 2025
Copy link
Collaborator

@mrubens mrubens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jun 14, 2025
@mrubens mrubens merged commit e618fa9 into RooCodeInc:main Jun 14, 2025
15 checks passed
@github-project-automation github-project-automation bot moved this from Triage to Done in Roo Code Roadmap Jun 14, 2025
@github-project-automation github-project-automation bot moved this from New to Done in Roo Code Roadmap Jun 14, 2025
@elianiva elianiva deleted the feat/better-history-ui branch June 14, 2025 04:29
cte pushed a commit that referenced this pull request Jun 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. lgtm This PR has been approved by a maintainer size:XXL This PR changes 1000+ lines, ignoring generated files. UI/UX UI/UX related or focused

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants